search

keplergl / kepler.gl

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.
http://kepler.gl
MIT License
10.12k stars 1.71k forks source link

[Bug] Access Token field is missing from Add Custom Map Style page #2488

Open reubengan93 opened 6 months ago

reubengan93 commented 6 months ago

Describe the bug The access token field is missing from Add Custom Map Style page. I am unable to add new custom map styles because of this

To Reproduce Steps to reproduce the behaviour:

  1. Go to the base map tab
  2. Click on add customer map style
  3. See error

Expected behaviour There should be an access token field so that custom maps can be added

Screenshots Screenshot 2023-12-20 at 9 25 01 AM

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

birkskyum commented 5 months ago

Most map providers have the access token as part of the url in a query parameter

davidcalhoun commented 5 months ago

@birkskyum

Confirming that this is an actual regression. In an older version of kepler.gl there was an additional field to paste in a token. Note that in the screenshot there's also a skipped step 2 which reflects that something is missing:

1. Paste style url
3. Name your style

With a Mapbox the Style URL and Access token are two different strings.

birkskyum commented 5 months ago

@davidcalhoun Kepler.gl moved from proprietary mapbox to open source maplibre ecosystem per v3. Even though we technically could support mapbox styles, there is a legal issue because mapbox afaik only will allow usage of their services in combination with their renderer, effectively putting existing customers in situation of vendor lock-in. Examples of some more permissive style providers worth exploring are stadia maps, felt, carto, maptiler, protomaps or even self-hosting.