search

keplergl / kepler.gl

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.
http://kepler.gl
MIT License
10.29k stars 1.73k forks source link

Remove unused parts of translation files #2494

Open birkskyum opened 9 months ago

birkskyum commented 9 months ago

Adding a style previously requested an api key, but these fields are now commented out because a potential style api key are a part of the style url, so the translations aren't needed either.

it also resolves some step numbering inconsistencies:

before:

Screenshot 2023-12-21 at 22 51 35

after:

Screenshot 2024-03-12 at 19 17 28
birkskyum commented 6 months ago

@ibgreen , there is a bit of confusion about how to add custom styles. This clarified the translations and is a cleanup step.

There has for a long time (since before i started looking into kepler.gl) been a bug related to a disabled "add style" button that I'd like to debug when this is in.

netlify[bot] commented 2 months ago

Deploy Preview for keplergl2 ready!

Name Link
Latest commit c9f3283cf81f33fbe2aedd1a84b1ca805d58c1e5
Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/66a1dd771c5a480008bd9164
Deploy Preview https://deploy-preview-2494--keplergl2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

birkskyum commented 2 months ago

@akre54 , this is a bit of a cleanup step in continuation of the fix you made recently on the style url (https://github.com/keplergl/kepler.gl/pull/2564), so I've rebased it now that the style url's work.