search

keplergl / kepler.gl

Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.
http://kepler.gl
MIT License
10.11k stars 1.71k forks source link

[Bug] Fix setup on first install #2563

Closed akre54 closed 2 months ago

akre54 commented 2 months ago

The Foursquare cloud provider needs @auth0/auth0-spa-js, but it wasn't specified in the package dependencies, preventing install. I just copied the version from examples/demo-app, which doesn't seem to use it directly.

netlify[bot] commented 2 months ago

Deploy Preview for keplergl2 failed.

Name Link
Latest commit 40ac4495344a1b9594fe8a00a2572d6b53b2b9cb
Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/6622925b5b56ab0008d5cf98
ibgreen commented 2 months ago

My expectation is that the Foursquare cloud provider dependencies should only be in the demo app, not in the main code base.

@macrigiuseppe Could you comment?

macrigiuseppe commented 2 months ago

My expectation is that the Foursquare cloud provider dependencies should only be in the demo app, not in the main code base.

@macrigiuseppe Could you comment?

@akre54 @ibgreen yeah auth0 should only be used in the demo app and not elsewhere. in fact the fsq cloud provider is only defined in the demo app

ibgreen commented 2 months ago

I already see the dependency in the demo app. https://github.com/keplergl/kepler.gl/blob/master/examples/demo-app/package.json#L13

@akre54 I wonder if you are using a non-standard build path?

akre54 commented 2 months ago

I wasn't able to install (it had been months since I pulled down master). Maybe swapping the order of the workspaces import would help? I was getting a typescript error on build that it couldn't find the package.

I tried cloning a new repo and am now getting another issue with unexpected tokens in loaders.gl. I'll close this but are you able to repro? Or is there something different I should be doing? FWIW I saw the same issue in my main clone, but then rebuilding made it work somehow