search

keplerproject / orbit

Orbit is an MVC web framework for Lua.
http://keplerproject.github.io/orbit/
118 stars 35 forks source link

Introducing the LPEG only version of orbit/routes.lua #22

Closed petsagouris closed 10 years ago

petsagouris commented 10 years ago

This is the version of routes.lua that has everything converted all the re.compile calls to lpeg calls instead. The routes bug ( #18 ) is still present and the system I work on hasn't got Lua 5.1 configured.

Running the test_routes.lua 1000 times with the problematic test commented out showed a 25% percent speed performance improvement.

kognix commented 10 years ago

Tested this with Lua 5.1.5 and runs fine... (and quickly) Agree routes bug #18 isn't yet resolved, but I see no reason why we can't pull this... faster and fewer dependencies is good!

mascarenhas commented 10 years ago

Merged. I can handle #18.

petsagouris commented 10 years ago

@mascarenhas The logic of the logic of the lpeg function local param=[...] seems to lie on line 25 and not on line 20 from my recent efforts to debug this, but nothing more than this observation yet.