search

keplerproject / orbit

Orbit is an MVC web framework for Lua.
http://keplerproject.github.io/orbit/
118 stars 35 forks source link

Publish 2.2.1 on luarocks? #32

Closed lilith closed 10 years ago

lilith commented 10 years ago

The latest rock I see is orbit 2.2.0-2, which doesn't work due to the module changes in the dependencies.

kognix commented 10 years ago

Hi Nathanael, during the last month or so considerable work has gone into preparing a 2.2.1 release that's compatible with the module changes. We're just awaiting approval to release - see comments on the previous issue #31 Meanwhile if you install from rocks-scm you should find it works well.

mascarenhas commented 10 years ago

Release date is updated, docs have been generated and uploaded to github pages, and release is tagged. @hishamhm, could you upload the rockspec to the repository?

hishamhm commented 10 years ago

Done! I fixed the URL and added the "lua 5.1 only" constraint to the rockspec as well:

https://github.com/keplerproject/orbit/blob/master/rockspec/orbit-2.2.1-1.rockspec

Will you do the honors at lua-l and keplerproject lists? :)

mascarenhas commented 10 years ago

Is the user still able to force the installation? Most of Orbit can work with Lua 5.2. The parts that do not work (and will need breaking changes to work) are htmlification and Orbit Pages.

hishamhm commented 10 years ago

Yes, if they use --nodeps.

My suggestion is to make the 5.1-only parts into separate rockspecs (orbit-pages and orbit-htmlify, perhaps) that depend on orbit. Grep tells me we can't just split them via rockspecs right now as there are some cross references here and there, but this could be a nice goal for 2.2.2: a core Orbit rock that's guaranteed to work with Lua 5.2 plus addon modules that are still 5.1-only.

kognix commented 10 years ago

Great news! Thx @mascarenhas @hishamhm :+1:

hishamhm commented 10 years ago

Thank you for the push!