search

keplerproject / wsapi

WSAPI is an API that abstracts the web server from Lua web applications.
http://keplerproject.github.io/wsapi
74 stars 33 forks source link

Publish wsapi.common.status_codes #1

Closed norman closed 14 years ago

norman commented 14 years ago

The first commit makes public the HTTP status defined in wsapi.common. The Xavante handler currently redefines these, and I also need them for the Mongrel2 handler I'm working on. It doesn't seem to make any sense to have to define basic stuff like this three times just to keep it local.

The second commit cleans up mixed tabs and spaces in one of the source files. Feel free to discard this commit if you prefer. I know Emacs handles this situation, but the source tends to look bad in vim and other editors. If you agree this is OK to change then I'll be happy to update the other files as well, but I wanted to ask before making a trivial, aesthetic change based on personal editing preferences. :)

mascarenhas commented 14 years ago

Maybe I am dense, but how do I apply these patches using the github web interface?

norman commented 14 years ago

You're not being dense, they just totally changed the interface. I'm not 100% sure how to do it now either... in fact, I usually just do it from the command line. Perhaps it's still located in the "fork queue"???

mascarenhas commented 14 years ago

Just did from the command line, but it didn't auto-close this pull request. Closing it now, thanks!

norman commented 14 years ago

Cool. So are you ok with me cleaning up the spaces/tabs in the rest of the files? I've been looking through the source code and the obsessive-compulsive side of me is coming out. :)

mascarenhas commented 14 years ago

Be my guest. :-) I thought my emacs was configured to not use tabs, I am going to check what is wrong.

norman commented 14 years ago

According to git blame, about 2 years ago you did not have Emacs configured that way. :)

norman commented 14 years ago

Ok, I made a new branch called "cleanups" and added the changes there. I tried to follow your formatting style as closely as possible, though in a few places I deviated a bit. Obviously this is a fairly low-priority branch, and please feel free to reformat anything however you prefer. I do think it helps though, because in a few places it was very hard to see where functions and conditionals opened or closed.

Some of this code hasn't been touched for a really long time, so do take a good look before applying and make sure I haven't broken anything. All the changed Lua files compile and the tests pass, but it's of course possible I missed something.

mascarenhas commented 14 years ago

Apparently I had to use setq-default instead of plain setq to set indent-tabs-mode to nil in my .emacs, duh. :-) I also did the nuclear option by adding some code (by JWZ) to auto-untabify any Lua or C file that I save.