keplerproject / wsapi

WSAPI is an API that abstracts the web server from Lua web applications.
http://keplerproject.github.io/wsapi
74 stars 33 forks source link

Allows to specify a domain when deleting a cookie. #31

Closed ignacio closed 10 years ago

ignacio commented 10 years ago

When a cookie has been set with a given domain (i.e. domain="example.com"), subsequent attempts to delete it will be ignored by the browser if the same domain is not provided.

So a 'domain' parameter is added to the 'delete_cookie' method in order to be able to delete those cookies.

hishamhm commented 10 years ago

Any compatibility concerns about merging this one?

ignacio commented 10 years ago

None. This is a new optional parameter. If not present, nothing will change in the Set-Cookie responses as they are now.

We may want a few days in case anyone else wants to chime in.

ignacio commented 10 years ago

Well, a few days have passed. Should we merge this?