keploy / keploy

Test generation for Developers. Generate tests and stubs for your application that actually work!
https://keploy.io
Apache License 2.0
3.4k stars 375 forks source link

add automatic port change if the port is busy #1051

Closed EraKin575 closed 6 months ago

EraKin575 commented 7 months ago

Is there an existing feature request for this?

Summary

since test and record mode run at same port, it will be beneficial to add a automatic port changing feature so both modes can be run at same time

Why should this be worked on?

..

Repository

keploy

github-actions[bot] commented 7 months ago

Thank you and congratulations 🎉 for opening your very first issue in keploy

EraKin575 commented 7 months ago

@charankamarapu can I have a hacktoberfest label on this?😁

charankamarapu commented 7 months ago

Hi @EraKin575 we already have an option to change the port using --proxyport flag. So if some one wants to change the port in some mode like record or test they can change it using that flag . So I dont think there is any issue here. If you are satisfied with the answer we can close the issue.

EraKin575 commented 7 months ago

@charankamarapu I am actually talking about automatically changing port if the port is busy

charankamarapu commented 7 months ago

Oh okay, then I guess we can take that up. But you can change the description of the issue because if someone want to run test and record they can use proxyport flag and do that, so we are not solving that problem. We are solving the problem which you mentioned in the above comment.

EraKin575 commented 7 months ago

Thanks @charankamarapu

nakulbh commented 7 months ago

@charankamarapu what is the default port that test and records run on ?

charankamarapu commented 7 months ago

The default port is 16789

EraKin575 commented 7 months ago

@charankamarapu Please review on my PR

EraKin575 commented 7 months ago

thanks @AkashKumar7902

nakulbh commented 7 months ago

@charankamarapu @EraKin575, I believe that simply incrementing the port won't resolve the issue. I've made some changes that I think are better suited to address this. Please review and share your thoughts on these modifications

charankamarapu commented 7 months ago

I guess there is some misunderstanding here, before raising a PR please ask to assign the issue to you. Right now there are two PRs and according to hackboterfest we decided to go by first come first serve. So @EraKin575 Pr will be reviewed . @nakulbh @EraKin575 please ask to assign before working on the issue. @nakulbh you can choose some other issue to work on. If this issue is not resolved even after completely reviewing after multiple revisions then I will consider @nakulbh PR.

charankamarapu commented 7 months ago

thanks @AkashKumar7902

🤔

nakulbh commented 6 months ago

@charankamarapu why my PR is closed

charankamarapu commented 6 months ago

Like I mentioned above only one PR will be merged out of both which are submitted. PR submitted by @EraKin575 is about to merge. So I have to close yours.