[BUG]: Fixed docker compose up containers to be removed

Yaxhveer commented 3 months ago

Related Issue

Info about Issue or bug

Closes: #1533

Describe the changes you've made

Docker trigger the start event when the application is again started.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write `NA` if there isn't)

A clear and concise description of it.

Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original	Updated
original screenshot	updated screenshot

Yaxhveer commented 3 months ago

@PranshuSrivastava Please review the PR

PranshuSrivastava commented 3 months ago

@Yaxhveer I think you have made the changes for the docker start command, that is listed in this issue #1539. Were you able to replicate the error for this issue? You need to remove the need to remove containers after docker compose up fails to run once. For some reason when you start the containers with Keploy again, Keploy is not able to find the desired container.

Yaxhveer commented 3 months ago

@PranshuSrivastava Kindly review the changes and let me know if it works.

Yaxhveer commented 2 months ago

@PranshuSrivastava Please review the changes

charankamarapu commented 2 months ago

Hey @Yaxhveer we have refactored the main code base. But the docker related testing is not yet done. We will notify you once that is done and then we continue with the PR if the issue is not solved by the refactored changes.

Yaxhveer commented 1 month ago

@PranshuSrivastava The PR has been updated according to the current codebase. Kindly the review the PR and let me know if it require any changes. Still there is a issue regarding blocking and panic in record mode as I specified here.

Yaxhveer commented 2 weeks ago

@PranshuSrivastava This PR requires the review.

keploy / keploy