keploy / keploy

Shadow Test generation for Developers. Generate tests and stubs for your application that actually work!
https://keploy.io
Apache License 2.0
3.84k stars 423 forks source link

[bug]: Add Email Check to Keploy Test Coverage Challenge #2082

Closed starvader13 closed 1 month ago

starvader13 commented 1 month ago

Is there an existing issue for this?

Current behavior

When subscribing to the Keploy test coverage Challenge, the system accepts an empty value or random value upon hitting the subscribe button. This allows the user to submit without any arguments, which negatively impacts both backend performance and frontend user experience.

Steps to reproduce

  1. Go to the Keploy test coverage Challenge section.
  2. Click on the subscribe button without entering an email or entering a random value.
  3. Observe that the subscription is accepted and renders a message Thanks for subscribing!.

Screenshots

image

Clicking Subscribe with Random / Empty Email image

Repository

website

github-actions[bot] commented 1 month ago

Thank you and congratulations 🎉 for opening your very first issue in keploy

starvader13 commented 1 month ago

@swpn0neel Have a look..

Proposed Solution

The solution could be broken into two sub-parts:

  1. Implement Zod Validation to ensure the email string is not empty and is a valid email format.
  2. Handle the render logic to provide a user-friendly message such as "The email entered needs to be a valid email."
Swpn0neel commented 1 month ago

@Swpn0neel Have a look..

Proposed Solution

The solution could be broken into two sub-parts:

  1. Implement Zod Validation to ensure the email string is not empty and is a valid email format.
  2. Handle the render logic to provide a user-friendly message such as "The email entered needs to be a valid email."

LGTM! Please go ahead!

PranavBarthwal commented 1 month ago

Is this issue up for collaboration?

Swpn0neel commented 1 month ago

Is this issue up for collaboration?

This is a solo issue!