keplr-io / quiver

Interactive convnet features visualization for Keras
https://keplr-io.github.io/quiver/
MIT License
1.76k stars 223 forks source link

Handle grayscale images and Theano vs. TF channel location difference #25

Closed dan-1d closed 7 years ago

dan-1d commented 7 years ago

Two features have been added: 1) images can be grayscale. Previously the input channels was assumed to be 3, which causes models to fail that expect 1 input channel. 2) Tensorflow and Theano use different ordering for the channel dimension. This fix corrects for it.

dan-1d commented 7 years ago

sorry.. was working on removing it as I got this

On Fri, Nov 18, 2016 at 10:58 AM, Jake Bian notifications@github.com wrote:

@jakebian commented on this pull request.

In npm-debug.log https://github.com/jakebian/quiver/pull/25#pullrequestreview-9285024:

+3 info using node@v5.2.0 +4 verbose stack Error: ENOENT: no such file or directory, open '/Users/gebhardt/git/quiver/package.json' +4 verbose stack at Error (native) +5 verbose cwd /Users/gebhardt/git/quiver +6 error Darwin 16.1.0 +7 error argv "/usr/local/Cellar/node/5.2.0/bin/node" "/usr/local/bin/npm" "start" +8 error node v5.2.0 +9 error npm v3.3.12 +10 error path /Users/gebhardt/git/quiver/package.json +11 error code ENOENT +12 error errno -2 +13 error syscall open +14 error enoent ENOENT: no such file or directory, open '/Users/gebhardt/git/quiver/package.json' +14 error enoent This is most likely not a problem with npm itself +14 error enoent and is related to npm not being able to find a file. +15 verbose exit [ -2, true ]

Remove the file please!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jakebian/quiver/pull/25#pullrequestreview-9285024, or mute the thread https://github.com/notifications/unsubscribe-auth/AD16XOlqhVtlPHgvorTfw1qlRqxb4H5Iks5q_fVtgaJpZM4K2tCc .

jakebian commented 7 years ago

Great, can you squash the last 3 commits though? The last 2 commits are not very meaningful.

jakebian commented 7 years ago

Awesome - I'll test it out before merging. Thanks @dan-1d!