keplr-io / quiver

Interactive convnet features visualization for Keras
https://keplr-io.github.io/quiver/
MIT License
1.75k stars 223 forks source link

Input shape and channels should be set based on image_dim_ordering #43

Closed bafu closed 7 years ago

bafu commented 7 years ago

In Keras backends document, image_dim_ordering controls how to interpret the information of image shape and input channel.

In current source code, keras.backend.backend() is used as the condition instead of keras.backend.image_dim_ordering(). TensorFlow backend is possible to use th as its dimension ordering convention, and vice versa.

jakebian commented 7 years ago

Merged your PR, good catch!