search

keplr-io / quiver

Interactive convnet features visualization for Keras
https://keplr-io.github.io/quiver/
MIT License
1.75k stars 223 forks source link

Feature/Added posibility to specify custom dataset mean and std #56

Closed ziky90 closed 6 years ago

ziky90 commented 6 years ago

This PR adds possibility to specify custom dataset mean and std.

ziky90 commented 6 years ago

@jakebian fixed stuff from your comment.

jakebian commented 6 years ago

Good stuff

jakebian commented 6 years ago

I guess we should also throw an error if someone passes in a std of 0 so that it doesn't divide by 0. This is actually why it's great that you removed the epsilon, because as is the program will either halt or return NaN if std of 0 is used, indicating an error, whereas if we left in the epsilon that division would return some huge number and carry on, which would be really confusing. We can add the error throwing later.

ziky90 commented 6 years ago

Ok I'l create a new PR with the check during this weekend.