Fix login hangs during redirect on custom state

keppelen / react-facebook-login

A Component React for Facebook Login

1.18k stars 406 forks source link

Closed maryqygao closed 6 years ago

maryqygao commented 6 years ago

Changes:

Fixes a bug where if a custom state prop is provided, the app will hang after redirecting back from Facebook.
This bug was caused by a query-substring check for "facebookdirect" on page-load. The login callback is never triggered if "facebookdirect" is not found. This has been changed into a check for possible redirect-keys code and granted_scopes to better reflect the intention.

Fixes:

digster commented 6 years ago

Someone kindly merge this. I am stuck for the same reason.

maryqygao commented 6 years ago

@keppelen FYI I did not do a version-bump in the PR. I would leave that up to you, hope we see a new version of the package published soon. :)

keppelen commented 6 years ago

+ react-facebook-login@4.1.0