search

keppelen / react-facebook-login

A Component React for Facebook Login
1.18k stars 406 forks source link

Fix Overriding current access token error #288

Closed jmayergit closed 4 years ago

jmayergit commented 4 years ago

https://github.com/keppelen/react-facebook-login/issues/286

Simple fix for the above issue. Needs testing

carlosalvarez91 commented 4 years ago

@jmayergit sorry for the newbie question but how can I update the module inside node_modules with your changes ? it looks like when I install the package, the facebook.js file inside the react-facebook-login module is already compiled into ES5

ViktorMeduneckij commented 4 years ago

@jmayergit sorry for the newbie question but how can I update the module inside node_modules with your changes ? it looks like when I install the package, the facebook.js file inside the react-facebook-login module is already compiled into ES5

You either have to specify jmayergit's branch in package.json next to this package, so that during installation, code would be pulled from this branch or wait for this to get merged and update your package's version. Second option is, of course, better, but who knows when this will get merged. ¯_(ツ)_/¯

carlosalvarez91 commented 4 years ago

@ViktorMeduneckij thanks very much, it looks like it will take a while to get merged, last commit was 27th december 2019

ViktorMeduneckij commented 4 years ago

@keppelen , could you merge this? Would really appreciate.