search

keppelen / react-facebook-login

A Component React for Facebook Login
1.18k stars 406 forks source link

Maintained fork #307

Open Dashue opened 4 years ago

Dashue commented 4 years ago

I've forked this repo and have created a new release including typings at "react-facebook-login": "https://github.com/Dashue/react-facebook-login#e97e169fb3e7102a73e6f77c04446deffc06ed2e",

I will be maintaining the fork as best I can and happy to join up with co-maintainers who are interested. If the fork gains usage my plain is to create react-facebook-login2 and publish on npm

mdanka commented 3 years ago

Thanks for making this! It would be lovely if you could make a release as a new package.

Dashue commented 3 years ago

Hey @mdanka I can't say I've got much experience with releasing npm packages. Want to join as a contributor and sort out a release?

mdanka commented 3 years ago

@Dashue I decided to take a different path after all, but thanks for the offer :) I'll let you know though if I need a release after all, I'd be happy to help out then!

Dashue commented 3 years ago

@mdanka what path did you take, may help others coming here? I remember not finding any alternatives that was typescript friendly at the time. Perhaps this has changed?

mdanka commented 3 years ago

@mdanka what path did you take, may help others coming here? I remember not finding any alternatives that was typescript friendly at the time. Perhaps this has changed?

I ended up using the button from here combined with some of the tricks in this package.

I have it available as a plotly dash package here: https://github.com/mdanka/dash_facebook_login

We could in theory release the react part as a separate npm package!