search

keppelen / react-facebook-login

A Component React for Facebook Login
1.18k stars 406 forks source link

removed the componentWillRecieveProps warning and reimplemented... #317

Closed vasilevich closed 3 years ago

vasilevich commented 3 years ago

updated to node-sass 5, because it didn't install. removed and reimplemented componentWillRecieveProps with the new react API to remove the react warnings and support react 17+ later on

ahummel25 commented 3 years ago

Can this be merged in? @mohamedhh @keppelen

samgermain commented 3 years ago

@mohamedhh @keppelen

I second @ahummel25

samgermain commented 3 years ago

@crisys11 @goldylucks @williamboman @mmahalwy @tobitos @revolunet @samuxyz @SterlingVix @adrianObel @jackfranklin @YouMinTW @jmayergit

Could someone merge this please?

williamboman commented 3 years ago

samgermain commented 3 years ago

@mohamedhh It looks like you approved these changes already back in Nov 2020, but it still wasn't merged. Who has write access?

I see this message below

This branch has no conflicts with the base branch
Only those with write access to this repository can merge pull requests.
mohamedhamza12 commented 3 years ago

@samgermain I believe only @keppelen does unfortunately. I've given up on this change being merged in and have opted to use Facebook's regular JavaScript API

samgermain commented 3 years ago

@mohamedhh I tried emailing and tweeting at him, I could call his workplace. What have you tried?

YouMinTW commented 3 years ago

have opted to use Facebook's regular JavaScript API @mohamedhh @samgermain

Me too I also use Facebook's regular JavaScript API

samgermain commented 3 years ago

🥳

liamhession commented 1 year ago

@vasilevich and @keppelen - This was merged in in the end, but it looks like the changes were never published to npm under a new version. So i still get the warnings about componentWillReceiveProps and it will likely break on React 18. But to echo the above guys, probably better to just use the regular Javascript API for fb login

andrii-shpontak commented 8 months ago

Is there a chance that it will be added to npm in the near future?

Alvinn2008 commented 3 months ago

![Uploading Screenshot_2024-06-05-12-42-56-564_com.facebook.katana.jpg…]()