search

keppelen / react-facebook-login

A Component React for Facebook Login
1.18k stars 406 forks source link

Support for React 17 #340

Open Rohan-Rajesh opened 2 years ago

Rohan-Rajesh commented 2 years ago

I recently started building a new project with nextjs so it defaulted to react version 17.0.2 now, I don't want to downgrade my react version as it would cause more issues than it would solve, could you please include support for React 17, it would be really appreciated Thanks

kharithomas commented 2 years ago

Hi @keppelen, any updates on this?

nathanmaru commented 2 years ago

updates?

dardino commented 2 years ago

updates?

glcheetham commented 2 years ago

I've updated the react version to 17.0.2 and published these changes to the registry as react17-facebook-login https://www.npmjs.com/package/react17-facebook-login

I also implemented the changes from pr #323 which switch out the classes for stateless components

I pushed these changes as a pull request #345 but in the meantime I'll be using my package so it doesn't break my build in a project using React 17

npm i --save react17-facebook-login

svante1987 commented 2 years ago

@glcheetham Thanks man! Saved me alot of headache. Crazy this hasent been implemented as of yet.

Nases commented 2 years ago

Any updates?

carlos-garcia commented 2 years ago

i tried with react 18 but seems it happens the same..

atnjqt commented 2 years ago

joining the chorus in requesting this, as I had to use --legacy-peer-deps to get this package installed for my project... obviously less than desirable 🤡

glcheetham commented 2 years ago

Guys you can save yourself some hassle and use this package instead:

https://www.npmjs.com/package/@greatsumini/react-facebook-login

It's a well-typed and actively maintained fork of this project, with a similar API.

npm i @greatsumini/react-facebook-login