kepstin / magicisrc

JS web tool to batch-submit ISRCs to MusicBrainz
18 stars 6 forks source link

feature: Add `musicbrainzid` as parameter alias #15

Closed RustyNova016 closed 1 month ago

RustyNova016 commented 2 months ago

Currently, the website looks for the parameter mbid in the URL. However, mbid often is associated with tracking and on browsers with any decent tracking protection (like Firefox and Librewolf, or extensions), this parameter get removed from the url.

So I added a alias that doesn't get flagged as tracking, and kept the old one as well for backward compatibility

kepstin commented 1 month ago

I've merged this code into the beta branch, and deployed it to https://magicisrc-beta.kepstin.ca/ - I've also updated the seeding documentation with information about the new parameter name and why someone might want to use it.

I'm testing this now and would appreciate any other feedback - hopefully i can deploy it to the main site soon.

RustyNova016 commented 1 month ago

Neat! I will be able to finally add isrc from harmony... Well I need to ready the PR over there too.

kepstin commented 1 month ago

Released in v20240922.0 with a fix to remove the duplicate parameter from the URL after the page loads.

RustyNova016 commented 1 month ago

Great!