Bug: Service restart in case of service failure

keptenkurk / BS440

Python code to talk to Medisana BS440 bluetooth enabled bathroom scale

MIT License

50 stars 34 forks source link

Bug: Service restart in case of service failure #108

Open Boldfor opened 1 year ago

Boldfor commented 1 year ago

In case the service dies, it will be re-started.

Boldfor commented 1 year ago

@keptenkurk, any chance you find some time to have a look at my three PRs from January? Two of them only deal with the documentation, and one (this one) includes a minor check to systemd if the service dies.

DjZU commented 1 year ago

I don't think this commit is fixing anything. I'd rather:

Restart=on-failure
Set exit codes to every sys.exit()
Run without privileges to prevent adapter reset (see #110)
Apply https://github.com/peplin/pygatt/commit/16e15db80360bcb53e0f83b3327dfa387e9249ba (see https://github.com/keptenkurk/BS440/issues/95#issuecomment-1504232250) to prevent scan from randomly hanging

Boldfor commented 1 year ago

@DjZU, thanks a lot for sharing your thoughts.

I'd love to incorporate your changes into the repository. However, as observable from my other contributions to this project, I'm already operating clearly way above my knowledge level, so I have to wait for someone else to incorporate what you propose. However, I'd be happy to test, in case someone incorporates your thoughts.

DjZU commented 1 year ago

@Boldfor, you're welcome. Operating clearly above my knowledge level is actually the way I've been learning! But I'm not familiar yet with pushing commits so I just share what works for me with the community hoping for someone to make the commits... Every step I described just give it a try!