keptn-archived / pitometer-ui

Pitometer is part of keptn. This Pitometer keptn UI repository is the first version of on out-of-the-box solution to enforce automated quality gates in your CI/CD Pipeline. It will work either with keptn as your deployment orchestrator or any other CI/CD tool such as Jenkins, Bamboo, Azure DevOps, Tekton, Argo CD, AWS CodePipeline or others.
Apache License 2.0
1 stars 3 forks source link

Doc Bug: count should be reportquery #10

Open ghost opened 4 years ago

ghost commented 4 years ago

Documentation Bug

The example provided is: /api/report?context=mytestcontext&count=7

This always returns 10 results, regardless of the count value:

/api/report?context=testproject/pre-prod/serviceA&count=1
/api/report: testproject/pre-prod/serviceA, 10 NaN
Query for last 10 Results
/favicon.ico
/api/report?context=testproject/pre-prod/serviceA&count=2
/api/report: testproject/pre-prod/serviceA, 10 NaN
Query for last 10 Results
/favicon.ico
/api/report?context=testproject/pre-prod/serviceA&count=20
/api/report: testproject/pre-prod/serviceA, 10 NaN
Query for last 10 Results
/favicon.ico
/api/report?context=testproject/pre-prod/serviceA&count=1
/api/report: testproject/pre-prod/serviceA, 10 NaN
Query for last 10 Results
/favicon.ico

I believe the correct parameter should be reportquery:

/api/report?context=testproject/pre-prod/serviceA&reportquery=3
/api/report: testproject/pre-prod/serviceA, 3 NaN
Query for last 3 Results
/favicon.ico
/api/report?context=testproject/pre-prod/serviceA&reportquery=4
/api/report: testproject/pre-prod/serviceA, 4 NaN
Query for last 4 Results
/favicon.ico
/api/report?context=testproject/pre-prod/serviceA&reportquery=10
/api/report: testproject/pre-prod/serviceA, 10 NaN
Query for last 10 Results