search

keptn-sandbox / monaco-service

Apache License 2.0
2 stars 3 forks source link

Introduce better status reporting with keptn 0.8 when calling monaco CLI #13

Open grabnerandi opened 3 years ago

grabnerandi commented 3 years ago

With Keptn 0.8 the monaco service can respond with a status and a detailed result message. Right now it only says: "Successfully ran monaco!" - even if the monaco-cli actually failed.

I suggest the monaco CLI output to be parsed and based on the actual result correctly set status and result message.

grabnerandi commented 3 years ago

HEre is an example where currently the monaco-sevice reports that monaco execution was successful where in fact there was one error as we can see in the log files of the monaco service

2021-06-22 10:09:08 ERROR       Failed to create DT object demo-delivery production (HTTP 400)!
    Response was: {"error":{"code":400,"message":"Unknown location(s): [GEOLOCATION-388A5AD15726CB6F]"}}, responsible config: tmp/monaco/0aadc6a3-530d-469c-b98f-183e69ea3e7d-production/projects/simplenode/synthetic-monitor/synthetic.json
2021-06-22 10:09:08 ERROR Errors during deployment! Check log!