keptn-sandbox / new-keptn-docs-engine

GSoC 2022 Project: New Documentation Site Engine
https://keptn-experimental-docs-site.netlify.app/
Apache License 2.0
6 stars 2 forks source link

feat: Add Prettier GitHub Action support to format docs #25

Closed iamrajiv closed 1 year ago

iamrajiv commented 2 years ago

Fixes: #23 Related: keptn/keptn.github.io#994

Currently, we will run the prettier checks for docs/**/*.{md,mdx} files only because mentors suggested making the PR as PoC.

netlify[bot] commented 2 years ago

Deploy Preview for keptn-experimental-docs-site ready!

Name Link
Latest commit 616a097c7b8aa0b94d1577c4c3335909a97a7e76
Latest deploy log https://app.netlify.com/sites/keptn-experimental-docs-site/deploys/631c721ab200cf0008457751
Deploy Preview https://deploy-preview-25--keptn-experimental-docs-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vadasambar commented 2 years ago

@iamrajiv how can I see https://github.com/keptn-sandbox/new-keptn-docs-engine/pull/25/files#diff-34dc18ecb47abe49e5a5814fc000ce86bee82b1a177c146fe6e6886bf090a5aeR20 in action? You might want to create a branch from prettier with messed up md file and see if the Auto commit works.

github-actions[bot] commented 1 year ago
⚡️ Lighthouse report for the changes in this PR: Category Score
🟠 Performance 52
🟢 Accessibility 100
🟢 Best practices 93
🟢 SEO 90
🟠 PWA 64

Lighthouse ran on https://deploy-preview-25--keptn-experimental-docs-site.netlify.app/

iamrajiv commented 1 year ago

Yeah @vadasambar to test Prettier GitHub Action I have added the PR here #31 and it is working fine.