search

keptn / lifecycle-toolkit

Toolkit for cloud-native application lifecycle management
https://keptn.sh
Apache License 2.0
289 stars 119 forks source link

KeptnTask defaults not provided #1866

Open agardnerIT opened 1 year ago

agardnerIT commented 1 year ago

The KeptnTaskDefinition spec shows retries and timeout parameters but doesn't list the defaults.

https://lifecycle.keptn.sh/docs/crd-ref/lifecycle/v1alpha3/#keptntaskdefinitionspec

agardnerIT commented 1 year ago

Running a task without specifying retries or timeout I see:

apiVersion: lifecycle.keptn.sh/v1alpha3
kind: KeptnTask
metadata:
spec:
  ...
  retries: 10
  ...
  timeout: 5m0s
  ...
RealAnna commented 1 year ago

The crd-ref-docs tool does not support this, however, if this is merged we could add the info as an annotation to kubebuilder to make it visible in the docs.

In the meantime, we could also add such info in the description field 🤔

thisthat commented 1 year ago

I'll put the label on hold since we depend on the external tool to provide this functionality

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.