Disable keptn-cert-manager Secret check when not enabled

keptn / lifecycle-toolkit

Toolkit for cloud-native application lifecycle management

https://keptn.sh

Apache License 2.0

313 stars 122 forks source link

Disable keptn-cert-manager Secret check when not enabled #2634

Closed odubajDT closed 10 months ago

odubajDT commented 11 months ago

Description

keptn-cert-manager provides a logic to check if keptn-certs Secret is in place in the Keptn default namespace. This code is used in lifecycle-operator and metrics-operator. The problem is that this check is not disabled when keptn-cert-manager is not enabled and installed as part of Keptn. For more information see the research results described here.

DoD

[ ] disable keptn-certs Secret check when certManager.enabled helm value is set to false in lifecycle-operator
[ ] disable keptn-certs Secret check when certManager.enabled helm value is set to false in metrics-operator
[ ] manual test with cert-manager.io

Notes

⚠️ This ticket should be merged into the epic/cert-manager-io feature branch!

geoffrey1330 commented 11 months ago

Could you please assign this issue to me once it refined.

odubajDT commented 11 months ago

Hi @geoffrey1330 this ticket needs to be refined first by the team. Afterwards I can assign it to you

sudiptob2 commented 11 months ago

Hi, I am how to read Helm values in Golang, especially when certain parameters like certManager.enabled aren't passed as environment variables in the Helm chart.

Can anyone point me to relevant code examples within the Keptn repo which is reading from helm values in Golang?

geoffrey1330 commented 11 months ago

Hi @sudiptob2 Here is an example where something similar was Implemented https://github.com/keptn/lifecycle-toolkit/pull/2607

sudiptob2 commented 11 months ago

Hi @sudiptob2 Here is an example where something similar was Implemented #2607

Great!

geoffrey1330 commented 11 months ago

Though am currently working on this issue.

sudiptob2 commented 11 months ago

I am learning, can I collaborate with you in this issue?

geoffrey1330 commented 11 months ago

Sure you could message me on the slack channel. always happy to collaborate.

odubajDT commented 11 months ago

@geoffrey1330 @sudiptob2 did you manage to sync about the collaboration? It seems like both of you have created a PR for this issue which looks exactly the same. Please sync with each other and close one of those

geoffrey1330 commented 11 months ago

Alright I Already told him to collaborate on my PR since the issue was assigned to me.

sudiptob2 commented 11 months ago

@odubajDT Please go ahead with @geoffrey1330 PR, I was trying to understand the issue that created the Draft PR because there was no open draft there for this issue.

odubajDT commented 11 months ago

Ok thank you guys, @sudiptob2 I am closing your PR, so it won't confuse anybody

odubajDT commented 10 months ago

This ticket is already resolved and merged into the feature branch, closing it