search

keptn / lifecycle-toolkit

Toolkit for cloud-native application lifecycle management
https://keptn.sh
Apache License 2.0
305 stars 121 forks source link

Introduce tests for lifecycle-operator bugs #3121

Open odubajDT opened 7 months ago

odubajDT commented 7 months ago

Recently multiple small bugs were found and fixed as part of this PR.

The places are:

Introduce unit tests to cover the affected functionality

SohamRatnaparkhi commented 7 months ago

Hi @odubajDT , I can try to solve this issue. Can you assign it to me?

Thank you!

odubajDT commented 7 months ago

Hi @SohamRatnaparkhi are you actively working on this issue? Since you have this issue assigned for aprox. 10 days, we usually unassign asignees from their issues if there is no activity to not block other potential contributors from starting to tackle them.

Thanks for the update!

SohamRatnaparkhi commented 7 months ago

Hey @odubajDT Really sorry for holding on to the issue. I'm busy right now and can't solve it. Feel free to assign it to someone else.

Once again, I'm really sorry :)

odubajDT commented 7 months ago

No worries, thank you very much for your answer! :) If you have time in the future, we would be happy if you reach out to us for potentially another issue!

Bharadwajshivam28 commented 6 months ago

Hey I can take on this one If no one is working

odubajDT commented 6 months ago

Hi @Bharadwajshivam28 are you actively working on this issue? Since you have this issue assigned for aprox. 3 weeks, we usually unassign asignees from their issues if there is no activity to not block other potential contributors from starting to tackle them.

Thanks for the update!

odubajDT commented 6 months ago

Due to inactivity, unassigning @Bharadwajshivam28 from this issue. Feel free to request a different issue!

YashPimple commented 6 months ago

Hi @odubajDT I would like to work on the above issue

odubajDT commented 6 months ago

@YashPimple I assigned it to you but please before you start, there is a small change required in the PR you have opened https://github.com/keptn/lifecycle-toolkit/pull/3143. try to please finish this one first before you start with a new one

Jay179-sudo commented 3 months ago

Hi! @odubajDT, I would like to take up this issue.

Since the non-blocking mode does not introduce any errors in the controller, we can write a unit test with a mock handler that does not return any errors when the KeptnAppVersionStatus resembles the manifest in the docs

Am I correctly understanding the task here?

mowies commented 2 months ago

@Jay179-sudo sure thing, I assigned it to you