search

keptn / lifecycle-toolkit

Toolkit for cloud-native application lifecycle management
https://keptn.sh
Apache License 2.0
307 stars 122 forks source link

Missing KeptnAppVersion/KeptnWorkloadVersion span when one of the lifecycle phases fails #3130

Closed odubajDT closed 7 months ago

odubajDT commented 7 months ago

Description

In the current state, when one of the phases fails (it does not matter whether on KeptnApp or KeptnWorkload level) the KeptnAppVersion span is not ended properly (and missing completely), which leads to a wrong child/parent structure when reviewing the results in Jeager or Grafana. The same problem is present for KeptnWorkloadVersion span, when one of the KeptWorkload phases fail.

Failure on KeptnApp level

Screenshot 2024-02-27 at 12 59 02

Failure on KeptnWorkload level

Screenshot 2024-02-27 at 12 47 45

Expected behavior

The spans should be correctly formatted and the KeptnAppVersion/KeptnWorkloadVersion span should exist even if the deployment of the application fails.

thisthat commented 7 months ago

it is unclear to me what do you mean by "correctly formatted". We do not have client/server types so there is no need for a child to finish before a parent.

odubajDT commented 7 months ago

it is unclear to me what do you mean by "correctly formatted". We do not have client/server types so there is no need for a child to finish before a parent.

True, we can then format the problem that the KeptnAppVersion span is missing.