smuda commented 3 months ago

Description

Allow removal of runAsUser and runAsGroup when running on openshift.

Fixes #3414

How to test

I've added a test under .github/scripts/.helm-tests and I hope that will run automatically together with the other tests, even though the github actions didn't run in my fork.

At least make helm-test works nicely :-).

Checklist

[ ] My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated into multiple PRs)
[X] I used descriptive commit messages to help reviewers understand my thought process
[x] I signed off all my commits according to the Developer Certificate of Origin (DCO) see Contribution Guide
[ ] My PR title is formatted according to the semantic PR conventions described in the Contribution Guide
[x] My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
[X] I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
[X] I have performed a self-review of my code
[X] I have made corresponding changes to the documentation (if needed)
[ ] My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
[X] New and existing unit and integration tests pass locally with my changes

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.33%. Comparing base (ed152f0) to head (87cae22). Report is 6 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3415 +/- ## ========================================== + Coverage 85.29% 85.33% +0.04% ========================================== Files 167 167 Lines 7412 7412 ========================================== + Hits 6322 6325 +3 + Misses 801 799 -2 + Partials 289 288 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3415/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | [Flag](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3415/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | Coverage Δ | | |---|---|---| | [certificate-operator](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `69.23% <ø> (ø)` | | | [component-tests](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `58.04% <ø> (+0.24%)` | :arrow_up: | | [lifecycle-operator](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `83.46% <ø> (ø)` | | | [metrics-operator](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `88.32% <ø> (ø)` | | | [scheduler](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `34.74% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn#carryforward-flags-in-the-pull-request-comment) to find out more.

odubajDT commented 2 months ago

Hi @smuda thank you for your contribution! Do you please have the capacity to make the required changes in the following days? We are planning to do a release in the next days and we would like to have this fix merged until then. If you do not have the capacity, we will take over the PR.

Thank you in advance!

smuda commented 2 months ago

Thank you! I'll fix this tonight.

odubajDT commented 2 months ago