search

keptn / lifecycle-toolkit

Toolkit for cloud-native application lifecycle management
https://keptn.sh
Apache License 2.0
270 stars 111 forks source link

fix: introduce missing Role into keptn-cert-manager helm charts #3435

Closed odubajDT closed 2 months ago

odubajDT commented 2 months ago

Fixes: #3434

Changes

Testing

The fix was manually tested and it's working. Even the scenario with installed lifecycle-operator and disabled metrics-operator was tested and it's working. Automated tests will be provided in a follow-up.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.31%. Comparing base (6012bd7) to head (eb2745f). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3435 +/- ## ======================================= Coverage 85.31% 85.31% ======================================= Files 167 167 Lines 7415 7415 ======================================= Hits 6326 6326 Misses 800 800 Partials 289 289 ``` | [Flag](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3435/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | Coverage Δ | | |---|---|---| | [certificate-operator](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `69.23% <ø> (ø)` | | | [component-tests](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `58.04% <ø> (ø)` | | | [lifecycle-operator](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `83.42% <ø> (ø)` | | | [metrics-operator](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `88.32% <ø> (ø)` | | | [scheduler](https://app.codecov.io/gh/keptn/lifecycle-toolkit/pull/3435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn) | `34.74% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keptn#carryforward-flags-in-the-pull-request-comment) to find out more.
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud