search

keptn / lifecycle-toolkit

Toolkit for cloud-native application lifecycle management
https://keptn.sh
Apache License 2.0
303 stars 121 forks source link

docs: added container section #3580

Closed BalaadityaPatanjali closed 3 months ago

BalaadityaPatanjali commented 3 months ago

Fixes #3097

RealAnna commented 3 months ago

Hi @BalaadityaPatanjali thanks fr the contribution! Please check the pipeline here to see what links are not working

BalaadityaPatanjali commented 3 months ago

Hi @BalaadityaPatanjali thanks fr the contribution! Please check the pipeline here to see what links are not working

Markdown-link-check is failing because in docs/docs/guides/otel.md , link for setup of monitoring other namespaces is not working and i am not familiar with that at all. So, i don't think i should replace that link. A little guidance here would be appreciated.

mowies commented 3 months ago

@BalaadityaPatanjali that dead link was apparently moved to https://prometheus-operator.dev/kube-prometheus/kube/monitoring-other-namespaces/ Could you please update it as part of this PR?

BalaadityaPatanjali commented 3 months ago

@BalaadityaPatanjali that dead link was apparently moved to https://prometheus-operator.dev/kube-prometheus/kube/monitoring-other-namespaces/ Could you please update it as part of this PR?

I have updated the link. Please have a look at it.

BalaadityaPatanjali commented 3 months ago

Thank you for the contribution! 🚀

Thank you for the merge !