keptn / lifecycle-toolkit

Toolkit for cloud-native application lifecycle management
https://keptn.sh
Apache License 2.0
311 stars 123 forks source link

keptn_app_deploymentinterval: 9.223372036854776e+09 #3679

Closed DiiBBz closed 1 week ago

DiiBBz commented 2 months ago

Hi!

In my DORA grafana dashboard I get this huge number which skews my whole panel.

image

Checking more closely on keptn.svc.something:2222/metrics I find this

keptn_app_deploymentinterval{keptn_deployment_app_name="my-app",keptn_deployment_app_namespace="my-app",keptn_deployment_app_previousversion="2449103969",keptn_deployment_app_version="924330662",otel_scope_name="keptn/task",otel_scope_version=""} 9.223372036854776e+09

The number 9.2233... is the same as 2^63 which makes me think there is some kind of integer overflow? Not sure what caused this, but I believe I reverted to a previous deployment and when looking at the calculation between the versions it became 292 years.

DiiBBz commented 2 months ago

For now I just exclude numbers bigger than "1000000000 seconds".

By changing the dashboard from

"expr": "avg by(keptn_deployment_app_previousversion, keptn_deployment_app_version) (keptn_app_deploymentinterval{keptn_deployment_app_name=\"$Application\"})",

to

"expr": "avg by(keptn_deployment_app_previousversion, keptn_deployment_app_version) (keptn_app_deploymentinterval{keptn_deployment_app_name=\"$Application\"} < 1000000000)",
fernandonogueira commented 2 months ago

For now I just exclude numbers bigger than "1000000000 seconds".

By changing the dashboard from

"expr": "avg by(keptn_deployment_app_previousversion, keptn_deployment_app_version) (keptn_app_deploymentinterval{keptn_deployment_app_name=\"$Application\"})",

to

"expr": "avg by(keptn_deployment_app_previousversion, keptn_deployment_app_version) (keptn_app_deploymentinterval{keptn_deployment_app_name=\"$Application\"} < 1000000000)",

Thanks! I'll use the same condition for now

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.