Open avitex opened 5 years ago
Though it sounds completely fair to have more small variants of the model, I think subclassed models in this project should be restricted to the more widely known ones that people agree with, In my humble opinion. Or, we can have them as a parameterized form in the parent class if the option for the variants benefits the model hugely.
I think subclassed models in this project should be restricted to the more widely known ones that people agree with, In my humble opinion.
I completely agree, it would be a little optimistic to assume every model used ever would be present, and the line has to be drawn somewhere
A basic way to implement this would be simply defining ResNet50_1by2 variants like in this commit. However this would break the convention of the provided ImageNet weights (unless they were generated of course). Instead would propose a generic
filter_mult
arg which would be used like so:With any value other than
1
, an error would be thrown if weights still specified 'imagenet':Happy to submit a PR for this :)