keras-team / keras-applications

Reference implementations of popular deep learning models.
Other
2k stars 910 forks source link

version in setup.py, 1.0.2, is incorrect for the 1.0.4 tag #32

Closed jjhelmus closed 5 years ago

jjhelmus commented 6 years ago

The version recorded in the setup.py file for the 1.0.4 tag is 1.0.2, which is incorrect. The sdist on PyPI has the correct version in the setup.py file.

This can causes issues if a checkout of the git tag is used as the mean to install keras-applications as the incorrect version will be recorded in the metadata.

I do not think anything should be done to fix this as changing a tag is a bad procedure. I think it is useful to have this in the issue tracker in case anyone else runs into the issue.

taehoonlee commented 6 years ago

cc @fchollet