keras-team / keras-autodoc

Documentation autogeneration utilities.
Apache License 2.0
30 stars 22 forks source link

Update for Sphinx >= 4.0 #93

Closed jxtngx closed 2 years ago

jxtngx commented 2 years ago

resolves issue#92

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

jxtngx commented 2 years ago

Steps taken:

def get_signature_end(function):
    sig = signature(function)
    signature_end = stringify_signature(sig, show_annotation=False)
    if utils.ismethod(function):
        signature_end = signature_end.replace("(self, ", "(")
        signature_end = signature_end.replace("(self)", "()")
    return signature_end
gabrieldemarmiesse commented 2 years ago

Sadly I don't have many right anymore in this repository. I can't approve the workflow to run. Maybe this repo could be transferred to my github username, so that I can continue to maintain it? @qlzh727 what do you think? Can we transfer this repo under @gabrieldemarmiesse ? Or do you want to keep it there and re-add me as maintainer?

jxtngx commented 2 years ago

The commit at bab0aa5 resolved the remaining failed test. Screen Shot 2022-04-19 at 1 41 03 PM