search

keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

Enable codecov flags and coverage carryover for keras_core and keras_… #841

Closed kiukchung closed 1 year ago

kiukchung commented 1 year ago

Does three things:

  1. Enables codecov flags (keras_core and keras_core.applications) so that those test coverages can be tracked and viewed in the UI separately.
  2. Enables carryover coverage for keras_core.applications since the apps tests are not always run.
  3. Tags each codecov upload with PYTHON and KERAS_BACKEND env vars
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +5.09% :tada:

Comparison is base (49e5b06) 70.90% compared to head (b16ae86) 75.99%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #841 +/- ## ========================================== + Coverage 70.90% 75.99% +5.09% ========================================== Files 344 328 -16 Lines 33300 31099 -2201 Branches 6409 6051 -358 ========================================== + Hits 23612 23635 +23 + Misses 8093 5866 -2227 - Partials 1595 1598 +3 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/841/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/841/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `75.91% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more. [see 27 files with indirect coverage changes](https://app.codecov.io/gh/keras-team/keras-core/pull/841/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fchollet commented 1 year ago

Thanks for the PR! Does the PR still need anything in order to graduate from draft status?

kiukchung commented 1 year ago

Thanks for the PR! Does the PR still need anything in order to graduate from draft status?

Yep, still need to get the carry-forward working for keras_core.applications coverage and make keras_core coverage ignore keras_core.applications.* module.