keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

Increase test coverage + Fixing bug in `static_call` #847

Closed Faisal-Alsrheed closed 12 months ago

Faisal-Alsrheed commented 1 year ago

This PR aims to increase the test coverage +

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% :tada:

Comparison is base (ab45558) 75.99% compared to head (9fb59b6) 76.04%. Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #847 +/- ## ========================================== + Coverage 75.99% 76.04% +0.04% ========================================== Files 328 328 Lines 31099 31137 +38 Branches 6051 6061 +10 ========================================== + Hits 23635 23679 +44 + Misses 5866 5863 -3 + Partials 1598 1595 -3 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/847/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/847/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `75.95% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/keras-team/keras-core/pull/847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras\_core/activations/activations.py](https://app.codecov.io/gh/keras-team/keras-core/pull/847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS9hY3RpdmF0aW9ucy9hY3RpdmF0aW9ucy5weQ==) | `90.82% <100.00%> (+4.71%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/keras-team/keras-core/pull/847/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fchollet commented 12 months ago

Thanks for the PR!

To best increase test coverage, I suggest using the codecov reports as a guide: https://app.codecov.io/gh/keras-team/keras-core/tree/main/keras_core

In particular focus on the saving/, utils/, trainers/, models/ namespaces.

Faisal-Alsrheed commented 12 months ago

Thanks for the PR!

To best increase test coverage, I suggest using the codecov reports as a guide: https://app.codecov.io/gh/keras-team/keras-core/tree/main/keras_core

In particular focus on the saving/, utils/, trainers/, models/ namespaces.

Thank you for your feedback.

I have just found out about seeing what line hasn’t been covered inside CodeCov. Very cool tool. Before, It was not easy for me to quickly find out untested lines.

But now I will be more than happy to do this task almost everyday on my free time.