search

keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

Update minimum python version to 3.9 to align with TF/JAX #848

Closed sampathweb closed 1 year ago

sampathweb commented 1 year ago

Currently the tests are running with JAX==0.4.13 which was the last version that supported Python 3.8. The latest jax version is 0.4.14. TensorFlow also has dropped python 3.8 in the upcoming 2.14 release. Numpy has already dropped it. So updating keras-core to use Python 3.9 as the minimum version.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (ab45558) 75.99% compared to head (f00f113) 75.99%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #848 +/- ## ======================================= Coverage 75.99% 75.99% ======================================= Files 328 328 Lines 31099 31099 Branches 6051 6051 ======================================= Hits 23635 23635 Misses 5866 5866 Partials 1598 1598 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/848/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/848/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `75.91% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ianstenbit commented 1 year ago

The PR title currently says 3.8, but I think it should be 3.9, right?

I think updating to 3.9 for KerasCV should be fine.

sampathweb commented 1 year ago

The PR title currently says 3.8, but I think it should be 3.9, right?

I think updating to 3.9 for KerasCV should be fine.

Thanks. Updated the PR title to 3.9.