Closed mattdangerw closed 1 year ago
Patch coverage: 100.00%
and project coverage change: -6.67%
:warning:
Comparison is base (
ab45558
) 75.99% compared to head (110a256
) 69.33%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The torch failure here looks unrelated. Could it be a flake?
Style nit, remove return type from
optimizer.apply
, so it is 1-1 with the signature foroptimizer.stateless_apply
. We can leave the iterations return type onapply_gradients
for compat with tf.keras. It seems mostly for compat, and has no stateless version.