keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

Respect the $KERAS_HOME environment variable for get_file #868

Closed mattdangerw closed 12 months ago

mattdangerw commented 12 months ago

Let me know if we want a test for this somehow, we don't really have test coverage for config.py or keras.json right now.

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 77.77% and no project coverage change.

Comparison is base (5a46100) 76.38% compared to head (0a19872) 76.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #868 +/- ## ======================================= Coverage 76.38% 76.38% ======================================= Files 329 329 Lines 31308 31311 +3 Branches 6093 6093 ======================================= + Hits 23915 23918 +3 Misses 5809 5809 Partials 1584 1584 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/868/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/868/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `76.29% <77.77%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/keras-team/keras-core/pull/868?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras\_core/backend/config.py](https://app.codecov.io/gh/keras-team/keras-core/pull/868?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS9iYWNrZW5kL2NvbmZpZy5weQ==) | `55.29% <71.42%> (+1.07%)` | :arrow_up: | | [keras\_core/utils/file\_utils.py](https://app.codecov.io/gh/keras-team/keras-core/pull/868?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS91dGlscy9maWxlX3V0aWxzLnB5) | `62.44% <100.00%> (+0.17%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.