keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

`run_layer_test` also runs symbolic calls when `input_data` is provided. #870

Closed hertschuh closed 12 months ago

hertschuh commented 12 months ago

This uncovered an issue in one layer and an issue in a test.

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.03% :tada:

Comparison is base (50c5f9a) 76.40% compared to head (9563dc1) 76.43%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #870 +/- ## ========================================== + Coverage 76.40% 76.43% +0.03% ========================================== Files 329 329 Lines 31327 31333 +6 Branches 6095 6100 +5 ========================================== + Hits 23934 23949 +15 + Misses 5809 5803 -6 + Partials 1584 1581 -3 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/870/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/870/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `76.33% <76.92%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/keras-team/keras-core/pull/870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras\_core/layers/preprocessing/hashed\_crossing.py](https://app.codecov.io/gh/keras-team/keras-core/pull/870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS9sYXllcnMvcHJlcHJvY2Vzc2luZy9oYXNoZWRfY3Jvc3NpbmcucHk=) | `77.92% <50.00%> (+3.56%)` | :arrow_up: | | [keras\_core/testing/test\_case.py](https://app.codecov.io/gh/keras-team/keras-core/pull/870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS90ZXN0aW5nL3Rlc3RfY2FzZS5weQ==) | `85.90% <81.81%> (-0.53%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/keras-team/keras-core/pull/870/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.