search

keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

Fix `model.save` API for legacy H5 format #891

Closed nkovela1 closed 10 months ago

nkovela1 commented 10 months ago

model.save was not updated to reflect the legacy format's existence. This keeps the API in line with keras.saving.save_model.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% :tada:

Comparison is base (94b5361) 76.56% compared to head (33b5f6f) 76.61%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #891 +/- ## ========================================== + Coverage 76.56% 76.61% +0.05% ========================================== Files 329 329 Lines 31429 31437 +8 Branches 6114 6116 +2 ========================================== + Hits 24064 24086 +22 + Misses 5786 5779 -7 + Partials 1579 1572 -7 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/891/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/891/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `76.52% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/keras-team/keras-core/pull/891?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras\_core/models/model.py](https://app.codecov.io/gh/keras-team/keras-core/pull/891?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS9tb2RlbHMvbW9kZWwucHk=) | `71.83% <100.00%> (+4.97%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/keras-team/keras-core/pull/891/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.