search

keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

Increase test coverage + Fix `save_model_to_hdf5` + Improve `is_remote_path` + Fix `is_remote_path` #900

Closed Faisal-Alsrheed closed 10 months ago

Faisal-Alsrheed commented 10 months ago

This PR aims to increase the robustness of the codebase by improving test coverage, fixing existing functions, and adding new tests to validate the changes made.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +7.04% :tada:

Comparison is base (74a4e7f) 76.78% compared to head (021068b) 83.83%. Report is 56 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #900 +/- ## ========================================== + Coverage 76.78% 83.83% +7.04% ========================================== Files 329 318 -11 Lines 31431 28731 -2700 Branches 6113 5486 -627 ========================================== - Hits 24134 24086 -48 + Misses 5726 3140 -2586 + Partials 1571 1505 -66 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/900/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/900/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `83.73% <100.00%> (+7.04%)` | :arrow_up: | | [keras_core-jax](https://app.codecov.io/gh/keras-team/keras-core/pull/900/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `67.17% <100.00%> (?)` | | | [keras_core-numpy](https://app.codecov.io/gh/keras-team/keras-core/pull/900/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `60.64% <100.00%> (?)` | | | [keras_core-tensorflow](https://app.codecov.io/gh/keras-team/keras-core/pull/900/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `66.97% <100.00%> (?)` | | | [keras_core-torch](https://app.codecov.io/gh/keras-team/keras-core/pull/900/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `69.23% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/keras-team/keras-core/pull/900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras\_core/utils/file\_utils.py](https://app.codecov.io/gh/keras-team/keras-core/pull/900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS91dGlscy9maWxlX3V0aWxzLnB5) | `66.06% <100.00%> (+3.61%)` | :arrow_up: | ... and [54 files with indirect coverage changes](https://app.codecov.io/gh/keras-team/keras-core/pull/900/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Faisal-Alsrheed commented 10 months ago

@fchollet Thank you for your feedback. I am still working on your comments. I will will let you know once it is ready