keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

fix torch error for bincount #927

Closed divyashreepathihalli closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 96.96% and project coverage change: -4.98% :warning:

Comparison is base (a92593f) 83.69% compared to head (8739f8c) 78.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #927 +/- ## ========================================== - Coverage 83.69% 78.71% -4.98% ========================================== Files 318 318 Lines 28735 28760 +25 Branches 5483 5488 +5 ========================================== - Hits 24049 22639 -1410 - Misses 3168 4674 +1506 + Partials 1518 1447 -71 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/927/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/927/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `78.65% <96.96%> (-4.94%)` | :arrow_down: | | [keras_core-jax](https://app.codecov.io/gh/keras-team/keras-core/pull/927/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `67.00% <36.36%> (-0.04%)` | :arrow_down: | | [keras_core-numpy](https://app.codecov.io/gh/keras-team/keras-core/pull/927/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `60.32% <42.42%> (+0.01%)` | :arrow_up: | | [keras_core-tensorflow](https://app.codecov.io/gh/keras-team/keras-core/pull/927/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `?` | | | [keras_core-torch](https://app.codecov.io/gh/keras-team/keras-core/pull/927/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `69.12% <48.48%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/keras-team/keras-core/pull/927?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras\_core/layers/preprocessing/discretization.py](https://app.codecov.io/gh/keras-team/keras-core/pull/927?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS9sYXllcnMvcHJlcHJvY2Vzc2luZy9kaXNjcmV0aXphdGlvbi5weQ==) | `82.35% <ø> (ø)` | | | [keras\_core/utils/numerical\_utils.py](https://app.codecov.io/gh/keras-team/keras-core/pull/927?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS91dGlscy9udW1lcmljYWxfdXRpbHMucHk=) | `84.48% <83.33%> (ø)` | | | [keras\_core/backend/jax/numpy.py](https://app.codecov.io/gh/keras-team/keras-core/pull/927?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS9iYWNrZW5kL2pheC9udW1weS5weQ==) | `98.83% <100.00%> (+0.02%)` | :arrow_up: | | [keras\_core/backend/numpy/numpy.py](https://app.codecov.io/gh/keras-team/keras-core/pull/927?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS9iYWNrZW5kL251bXB5L251bXB5LnB5) | `98.73% <100.00%> (+0.03%)` | :arrow_up: | | [keras\_core/backend/torch/numpy.py](https://app.codecov.io/gh/keras-team/keras-core/pull/927?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS9iYWNrZW5kL3RvcmNoL251bXB5LnB5) | `95.25% <100.00%> (+0.07%)` | :arrow_up: | ... and [39 files with indirect coverage changes](https://app.codecov.io/gh/keras-team/keras-core/pull/927/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fchollet commented 10 months ago

Also -- I've disabled the failing test yesterday for NumPy and torch, please reenable it.