keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

Hacky fix for dictionary output with tf 2.14 #933

Closed mattdangerw closed 10 months ago

mattdangerw commented 10 months ago

See https://github.com/keras-team/keras/issues/18399 for more info. And other workaround we could consider.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +7.00% :tada:

Comparison is base (a465816) 76.82% compared to head (55e9c46) 83.83%. Report is 49 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main keras-team/keras-core#933 +/- ## ========================================== + Coverage 76.82% 83.83% +7.00% ========================================== Files 329 318 -11 Lines 31427 28743 -2684 Branches 6112 5491 -621 ========================================== - Hits 24144 24096 -48 + Misses 5719 3141 -2578 + Partials 1564 1506 -58 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/933/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `83.72% <66.66%> (+6.99%)` | :arrow_up: | | [keras_core-jax](https://app.codecov.io/gh/keras-team/keras-core/pull/933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `67.16% <16.66%> (?)` | | | [keras_core-numpy](https://app.codecov.io/gh/keras-team/keras-core/pull/933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `60.63% <16.66%> (?)` | | | [keras_core-tensorflow](https://app.codecov.io/gh/keras-team/keras-core/pull/933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `66.97% <66.66%> (?)` | | | [keras_core-torch](https://app.codecov.io/gh/keras-team/keras-core/pull/933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `69.22% <16.66%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/keras-team/keras-core/pull/933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras\_core/ops/function.py](https://app.codecov.io/gh/keras-team/keras-core/pull/933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#diff-a2VyYXNfY29yZS9vcHMvZnVuY3Rpb24ucHk=) | `92.68% <100.00%> (+0.27%)` | :arrow_up: | ... and [49 files with indirect coverage changes](https://app.codecov.io/gh/keras-team/keras-core/pull/933/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.