keras-team / keras-core

A multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Apache License 2.0
1.27k stars 115 forks source link

Move Image classification with ConvMixer to keras-core #941

Closed divyashreepathihalli closed 10 months ago

divyashreepathihalli commented 10 months ago
codecov[bot] commented 10 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9bf92c8) 83.83% compared to head (d528e22) 83.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main keras-team/keras-core#941 +/- ## ======================================= Coverage 83.83% 83.83% ======================================= Files 319 319 Lines 28879 28879 Branches 5529 5529 ======================================= Hits 24211 24211 Misses 3148 3148 Partials 1520 1520 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras-core/pull/941/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras_core](https://app.codecov.io/gh/keras-team/keras-core/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `83.72% <ø> (ø)` | | | [keras_core-jax](https://app.codecov.io/gh/keras-team/keras-core/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `67.11% <ø> (ø)` | | | [keras_core-numpy](https://app.codecov.io/gh/keras-team/keras-core/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `60.56% <ø> (ø)` | | | [keras_core-tensorflow](https://app.codecov.io/gh/keras-team/keras-core/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `67.08% <ø> (ø)` | | | [keras_core-torch](https://app.codecov.io/gh/keras-team/keras-core/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `69.08% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

divyashreepathihalli commented 10 months ago

Thanks for the PR! Does the example work with all backends? If so we should move it out of the tensorflow directory.

I had to change data augmentation from a sequential model to a function for it to work with all the backends. I have filed an issue with a repro here - https://github.com/keras-team/keras/issues/18396

fchollet commented 10 months ago

Keras Core is becoming Keras 3, and we're switching development to the main repository! Please reopen this PR in the keras-team/keras repository. Unfortunately we aren't able to automatically transfer PRs (but we have transferred all issues).