Closed innat closed 2 years ago
Thanks for this FR, could you provide the link to the original paper so that we can take a look?
In general, I think we are open accept new application models if they are widely recognized. Currently we might host it in keras.application, but will very likely to move them to keras-cv repository, which is targeted for CV specific components.
Just FYI, you can take a look for the new guidance for adding application to keras in https://github.com/keras-team/keras/pull/15447.
@qlzh727 The paper link is provided.
I'm really excited about the keras-cv repo. Any good news?
So far we are scoping it and draft the roadmap for it. Will have more details later this year.
@Rishit-dagli are you interested to contribute here?
Thanks for the reference. If you would like to contribute, you are welcome to send it to keras CV, which will be new home for cv related application model.
@Rishit-dagli are you interested to contribute here?
Context: tensorflow/models#10269
Thanks @bhack , I would definitely love to take this up!
So far we are scoping it and draft the roadmap for it. Will have more details later this year.
@qlzh727 Please do let me know if this should be contributed to keras.applications
or keras-cv
.
Until then I will start reading the contributing guidelines for both and take a look at a couple of past PRs as well.
@qlzh727 any update on this. luke informed us that the new model will be placed to keras-application
for now. FYI, there is already a version 2 of swin-transformer.
Sorry for the late reply. We probably have to host this in the keras/application for now. Eventually we will move this to keras-cv, but we are not ready yet. Feel free to send PR if you have any.
@qlzh727 Thanks for clarifying. cc. @Rishit-dagli
@qlzh727 Could you please move this issue to keras-cv? I think it's more fit there now.
Thanks for the notice.
It seems I created a duplicate issue. Yes we'd like to accept the contribution as a keras-application style model. Is there any way to split the work, for example, porting on SWIN-T Base first?
Can we close this for https://github.com/keras-team/keras-cv/issues/671?
If you open a GitHub issue, here is our policy:
It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead). The form below must be filled out.
Here's why we have that policy:.
Keras developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.
System information.
TensorFlow version (you are using): 2.6 Are you willing to contribute it (Yes/No): Yes
Describe the feature and the current behavior/state.
Describe the feature clearly here. Be sure to convey here why the requested feature is needed. Any brief description of the use-case would help.
Paper: Swin Transformer: Hierarchical Vision Transformer using Shifted Windows Original Code: https://github.com/microsoft/Swin-Transformer?utm_source=catalyzex.com
It's a variant of the transformer model and achieves state-of-the-art performance or comparable performance with the best CNN-based models. It also contains enough citations (~250 at this moment) for addition to the package.
On ImageNet-1K and 22K, below is the comparable results with EfficientNet (CNN) models.
Will this change the current api? How? Yes. It will change as follows
Who will benefit from this feature? Keras users.
Contributing