search

keras-team / keras-cv

Industry-strength Computer Vision workflows with Keras
Other
998 stars 329 forks source link

Express cloudbuild as github action #907

Open bhack opened 1 year ago

bhack commented 1 year ago

Can we express our CloudBuild with the Gooogle Github Action?

This is an official example from the official google cloud Action repo: https://github.com/google-github-actions/setup-gcloud/tree/main/example-workflows/cloud-build

https://github.com/google-github-actions/setup-gcloud/blob/main/example-workflows/cloud-build/.github/workflows/cloud-build.yml

tanzhenyu commented 1 year ago

Can you elaborate on : 1) the benefits of doing so? 2) what are the potential downsides if we migrate?

bhack commented 1 year ago
  1. We have all the orchestration on a common well know DSL (Githu Action)
  2. I don't know specific limit, it is maintained by Google.
bhack commented 1 year ago

Also it is quite annoying that the Cloudbuild is always in failing by default for every new PR (when it is still not manually triggered).

It makes the PRs status and overview/lists very confusing.

LukeWood commented 1 year ago

Also it is quite annoying that the Cloudbuild is always in failing by default for every new PR (when it is still not manually triggered).

This is a good point, but I'm not sure we want to invest the resources to fix this at this time. Unfortunately, we don't have the GPU resources to run the tests for every single PR commit.

bhack commented 1 year ago

Unfortunately, we don't have the GPU resources to run the tests for every single PR commit.

I never asked this but as we manually request it to run it doesn't need to fail by default as it is not mandatory to have a default fail status.

LukeWood commented 1 year ago

I never asked this but as we manually request it to run it doesn't need to fail by default as it is not mandatory to have a default fail status.

Ok, how do we configure that? I'm happy to accept configuration for that. That would be really nice to have it default to yellow status.

bhack commented 1 year ago

Ok, how do we configure that? I'm happy to accept configuration for that. That would be really nice to have it default to yellow status.

I am not a manager of this repo so you need to set yourself: https://cloud.google.com/build/docs/automating-builds/github/build-repos-from-github#different_types_of_github-based_triggers

Then Github Action help community PRs, but it is a distinct topic (it was the other point of this ticket).

bhack commented 1 year ago

Just to make a blackbox reverse engineering, what I suppose is that you have configured it to trigger also on PRs but it is not required as you have probably configure also a custom trigger for the /gcburn pattern.