keras-team / keras-hub

Pretrained model hub for Keras 3
Apache License 2.0
764 stars 230 forks source link

Port Data Parallel Training example to multi-backend #1177

Open shivance opened 1 year ago

shivance commented 1 year ago

Link : https://github.com/keras-team/keras-io/blob/master/examples/nlp/data_parallel_training_with_keras_nlp.py

The tutorial was originally written in Keras, we need to port this to Keras Core with multi backend support.

rajchordia14 commented 1 year ago

Can I work on this issue?

shivance commented 1 year ago

Sure @rajchordia14 ! You are welcome to contribute. Please open a PR at keras-team/keras-io ! We can use this thread to discuss if you need any help!

shivance commented 1 year ago

Hi @rajchordia14 any update? are you stuck somewhere and need help?

rajchordia14 commented 1 year ago

Working on it, first ever contribution might take time. Apologies for delay

pranavvp16 commented 1 year ago

@rajchordia14 are you still working on this or can I take over and start working on it

shivance commented 1 year ago

@pranavvp16 you may start working on this if you still are interested. Please try to come up with a colab. Then we could iterate on it.

pranavvp16 commented 1 year ago

fine I'll start working today

pranavvp16 commented 1 year ago

@shivance I changed the imports according to the new keras-core and ran the example, the example ran fine with pytroch as backend but when backend is set to tensorflow there's an error. Below is the link to collab notebook pytorch as backend tensorflow as backend Seems there is something missing in optimizers file in tensorflow backend

shivance commented 1 year ago

This is strange, can you open a seperate issue to file this bug?

pranavvp16 commented 1 year ago

I should be opening the issue in keras-core repository right ?

shivance commented 1 year ago

keras-nlp for now

pranavvp16 commented 1 year ago

@shivance can I make the PR for converted code sample as it works with other backends, and once the above issue is fixed it will work with tensroflow too

shivance commented 1 year ago

Yes, please go ahead! Please open seperate issues for each bug you face. Keras team tracks all the work through github issues.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 180 days with no activity. It will be closed if no further activity occurs. Thank you.