search

keras-team / keras-hub

Pretrained model hub for Keras 3
Apache License 2.0
781 stars 237 forks source link

Add type annotations for TransformerEncoder and TransformerDecoder #19

Closed mattdangerw closed 1 year ago

mattdangerw commented 2 years ago

We would like to use type annotations in KerasNLP. We should add them for the encoder/decoder blocks...

https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/layers/transformer_decoder.py https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/layers/transformer_encoder.py

howl-anderson commented 2 years ago

I am familiar with TensorFlow/Keras and the transformer theory and implementations (from the TensorFlow Model Garden). I would like to take this task and will send a PR later.

mattdangerw commented 2 years ago

Thank you! Please tag me for review!

Stealth-py commented 2 years ago

Hey! Is this issue still open?

mattdangerw commented 2 years ago

@howl-anderson are you currently working on this?

howl-anderson commented 2 years ago

Yes, I'm still working on it. My city is on lockdown for more than one month because of COVID-19. It makes me have less time for this job. I'm sorry for the slow process. I will work hard for this, hopefully, send a PR within two weeks.

Stealth-py commented 2 years ago

Ah, alright. Stay safe!