search

keras-team / keras-hub

Pretrained model hub for Keras 3
Apache License 2.0
781 stars 237 forks source link

Add type annotations to the bert example #24

Closed mattdangerw closed 1 year ago

mattdangerw commented 2 years ago

We would like to use type annotations in KerasNLP. We should add them to the BERT example code in https://github.com/keras-team/keras-nlp/tree/master/examples/bert

howl-anderson commented 2 years ago

I am familiar with TensorFlow/Keras and the BERT theory and implementations (from the TensorFlow Model Garden). I would like to take this task and will send a PR later.

mattdangerw commented 2 years ago

Thank you! Please tag me for review!

aflah02 commented 2 years ago

Hey Is this issue still open?

howl-anderson commented 2 years ago

Hi @aflah02, sorry for the slow progress. I am still working on adding type annotations to the BERT.

aflah02 commented 2 years ago

Hey @howl-anderson That's cool, no need to say sorry I was just looking around :) and must've missed that you're already assigned

mattdangerw commented 1 year ago

Keras as a whole is not pursuing type annotations at the moment.